Conversation
There was a problem hiding this comment.
This just feels like a bad way to implement this imo. There’s no perm checks for placement or breaking, its manual place & break which is just prone to issues with other plugins, also you don’t set facing on the blockdata, does this work on all rotations?
I would make the bedroll a normal bed item, prevent placement if its not night time, and then post successful place do most of the existing logic. Then on wake auto break with the actual method and give the bed directly to the player. That way we actually call events properly.
We could also make a RebarBed block interface for onSleep, onWakeup, onSetSpawn which this could use but obv that can happen later (if ever)
There was a problem hiding this comment.
I don't see any realistic way on why the plugins should interact with the bed roll, but I can open an issue later I don't feel like adding that stuff because it doesn't seem that necessary to me nor I have a clear idea what you are trying to pitch (beside the permission checks)
There was a problem hiding this comment.
Just doing a skim and I think it would be nice if:
- There was a display entity line drawn from the origin to where you're currently looking
- The tape measure could handle sub-block distances
- The distance was shown live in the actionbar/bossbar. This might conflict with WAILA so not sure but maybe worth looking into
If you want to do that here that would be great, otherwise we can open issues
There was a problem hiding this comment.
I don't understand what do you mean in 2
There was a problem hiding this comment.
Also what methods should I use to send a display entity line to only the player ?
There was a problem hiding this comment.
In the Entity spawn lambda set visible by default to false and then use player#showenitity
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
( Bed roll )
I think sleeping bag would be a better name for bed roll tbh
Clicking 'leave bed' while using bed roll does not remove the bed
( Tape measure )
I was thinking with the tape measure it would draw the line as you dragged it - so every tick the line would update to end where you are looking. This would allow you to remove the 'position 1 set' and 'position 2 set' messages too
No way to clear tape measure line - maybe do when the player scrolls off it?
Would be better I think to calculate the distance immediately when position 2 is set instead of waiting for shift+right click
What would be really nice here is to use a text display which constantly teleports to where the player is looking and displays the current distance. This would make the tape measure a lot more useful
May be just me but left click for pos1 and right click for pos2 feels more natural?
Apologies I missed this for so long...
| tape_measure: | ||
| name: "Tape Measure" | ||
| lore: |- | ||
| <arrow> Measures the distance between two blocks in the same world |
There was a problem hiding this comment.
'in the same world' probably redundant
| <arrow> Breaks glass like material faster, includes: | ||
| <arrow> - All types of glass blocks | ||
| <arrow> - All types of glass panes | ||
| <arrow> - Sea Lantern | ||
| <arrow> - Glowstone Block | ||
| <arrow> - Redstone Lamp | ||
| <arrow> - Beacon |
There was a problem hiding this comment.
New lore suggestion:
<arrow> Breaks fragile blocks faster
<arrow> Works on <yellow>Glass Blocks</yellow>, <yellow>Glass Panes</yellow>, <yellow>Sea Lanterns</yellow>, <yellow>Glowstone Blocks</yellow>, <yellow>Redstone Lamps</yellow>, and <yellow>Beacons</yellow>
(2nd line looks way longer than it is because the tags)
4 participants
Fixes #683
Fixes #665
Fixes #653
Fixes #39