Skip to content

Update renderview.js #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 2 commits into from
Mar 25, 2026
Merged

Update renderview.js #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
039d841
Update renderview.js
almarklein Mar 25, 2026
34b79f1
Update pyodide backend
almarklein Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,5 @@ that uses `standardjs`. To format and lint your code locally:

* Install npm if you don't have it already.
* `npm install --global standard`
* `standard rendercanvas` (run this before committing changes to the JavaScript code)
* `standard rendercanvas --fix` (run this before committing changes to the JavaScript code)

28 changes: 15 additions & 13 deletions rendercanvas/core/renderview-pyodide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,22 @@ class PyodideRenderView extends BaseRenderView {
this.setThrottle(0)
}

onVisibleChanged (visible) {
this.pycanvas._onVisibleChanged(visible)
}

onResize (physicalWidth, physicalHeight, pixelRatio) {
// Set canvas physical size
this.viewElement.width = physicalWidth
this.viewElement.height = physicalHeight
// Notify canvas, so the render code knows the size
this.pycanvas._onResize(physicalWidth, physicalHeight, pixelRatio)
}

onEvent (event) {
this.pycanvas._onEvent(event)
if (event.type === 'resize') {
// Set canvas physical size
this.viewElement.width = event.pwidth
this.viewElement.height = event.pheight
// Notify canvas, so the render code knows the size
this.pycanvas._on_resize(event.pwidth, event.pheight, event.ratio)
} else if (event.type === 'close') {
this.pycanvas.close()
} else if (event.type === 'show') {
this.pycanvas._on_visible_changed(true)
} else if (event.type === 'hide') {
this.pycanvas._on_visible_changed(false)
} else {
this.pycanvas._on_event(event)
}
}
}

Expand Down
34 changes: 23 additions & 11 deletions rendercanvas/core/renderview.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
/*************************************************************************************************
renderview.css

This file is dedicated to the public domain under CC0 1.0.
This file is developed at https://github.com/pygfx/renderview, please contribute changes there.

*************************************************************************************************/

div.renderview-wrapper {
display: inline-block;
position: relative;
Expand All @@ -7,17 +15,21 @@ div.renderview-wrapper {
min-height: 32px;
}

div.renderview-wrapper img,
div.renderview-wrapper canvas {
div.renderview-wrapper .renderview-view {
display: block;
box-sizing: border-box;
width: 100%;
height: 100%;
background: none;
border-radius: 6px;
background: #777;
border: 1px solid rgba(127, 127, 127, 0.2);
}

div.renderview-wrapper .renderview-hidden {
display: none;
}

div.renderview-wrapper div.renderview-top {
div.renderview-wrapper .renderview-top {
display: none;
position: absolute;
box-sizing: border-box;
Expand All @@ -26,10 +38,11 @@ div.renderview-wrapper div.renderview-top {
height: 1.5em;
width: 100%;
border-radius: 6px 6px 0 0;
box-shadow: 0px -2px 0px 0px rgba(128, 128, 128, 0.5);
border: 1px solid rgba(127, 127, 127, 0.2);
border-bottom: 0;
}

div.renderview-wrapper div.renderview-top span {
div.renderview-wrapper .renderview-top span {
display: inline-block;
box-sizing: border-box;
overflow: hidden;
Expand All @@ -39,7 +52,7 @@ div.renderview-wrapper div.renderview-top span {
width: 100%;
}

div.renderview-wrapper div.renderview-resizer {
div.renderview-wrapper .renderview-resizer {
display: none;
position: absolute;
box-sizing: border-box;
Expand All @@ -55,16 +68,15 @@ div.renderview-wrapper.has-titlebar {
margin-top: 2em !important;
}

div.renderview-wrapper.has-titlebar div.renderview-top {
div.renderview-wrapper.has-titlebar .renderview-top {
display: block;
}

div.renderview-wrapper.has-titlebar img,
div.renderview-wrapper.has-titlebar canvas {
div.renderview-wrapper.has-titlebar .renderview-view {
border-top-left-radius: 0 !important;
border-top-right-radius: 0 !important;
}

div.renderview-wrapper.is-resizable div.renderview-resizer {
div.renderview-wrapper.is-resizable .renderview-resizer {
display: block;
}
Loading
Loading