add a function to register an unhandled promise rejection handler#7
Open
BuBuaBu wants to merge 1 commit intopyericz:masterfrom
Open
add a function to register an unhandled promise rejection handler#7BuBuaBu wants to merge 1 commit intopyericz:masterfrom
BuBuaBu wants to merge 1 commit intopyericz:masterfrom
Conversation
adriweb
reviewed
Oct 28, 2020
BuBuaBu
force-pushed
the
master
branch
2 times, most recently
from
b2aee88 to
6b534cd
Compare
Author
|
Hi @pyericz could you have a look at this PR? |
Contributor
|
Hi, any news ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a promise is rejected and the calling application fail or forget to catch it,
The error is silently ignored making things hard to debug.
This kind of mistake is considered has a fatal runtime error in nodejs.
We this PR, we can register a uniq and global "Unhandled Promise Rejection" handler. This way, the application can choose the way to manage this kind of issue. (logging, exit, ...)