BUG: add missing checks for nullptr in mm_new(|_nan)#547
Open
neutrinoceros wants to merge 1 commit intopydata:masterfrom
Open
BUG: add missing checks for nullptr in mm_new(|_nan)#547neutrinoceros wants to merge 1 commit intopydata:masterfrom
mm_new(|_nan)#547neutrinoceros wants to merge 1 commit intopydata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #526 as suggested
I note that the return value of
mm_newis already being checked for null pointers in some places but not all, which means it only moves the location of a segfault in at only some cases. I think we need to track this too (checking for null pointers everywhere these functions are called), but IMO it's okay to do as a follow up. Leaving it to @rgommers to advise here.