Conversation
|
@centromere Thanks for the PR. I'll take a look at it when I have a chance, though I don't think I agree with you about the timestamp format. |
|
After re-reading the OCFL spec and RFC3339, I believe that the spirit of the law is to allow both representations. I have not investigated too deeply, but I believe a dependency, after being bumped, is now emitting |
|
@centromere Interestingly, there was a timezone related failure in CI, but it didn't fail for me locally. In the mean time, I tried updating the crusty old github actions and applied all of the clippy fixes. Do you want to rebase your PR, and try again? |
Note: Section 3.5.3.1 of the OCFL specification requires that UTC be represented by "Z", not by "+00:00". The unit tests have been updated accordingly.
5d19a43 to
d5d8546
Compare
|
@centromere Try changing the timestamp in the assert in timestamp.to_rfc3339_opts(SecondsFormat::Secs, true) |
|
Thank you. |
Note: Section 3.5.3.1 of the OCFL specification requires that UTC be represented by "Z", not by "+00:00". The unit tests have been updated accordingly.