Merged
Conversation
Contributor
Keith-wright
commented
Mar 23, 2026
Keith-wright
commented
- `actions/checkout@v2`/`@v3` → `@v4` across all three workflows
- Replace archived `actions/create-release@v1` with `softprops/action-gh-release@v2.6.1` in `gh-release.yml`
- Add PHP 8.5 to test matrix in `test.yml`
- actions/checkout@v2/v3 -> @v4 across all workflows - Replace deprecated actions/create-release@v1 with softprops/action-gh-release@v2.6.1 - Add PHP 8.5 to test matrix
aonemd
approved these changes
Mar 24, 2026
.github/workflows/release.yml
Outdated
| echo "VERSION=$NEW_VERSION" >> $GITHUB_ENV | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 |
aonemd
requested changes
Mar 24, 2026
Member
aonemd
left a comment
aonemd
left a comment
There was a problem hiding this comment.
Tests are not running. You need to update the all the workflows' runner instance to ubuntu-latest
- actions/checkout@v4/v3 → @v6 across all three workflows - ubuntu-20.04 → ubuntu-latest in test.yml
The Pusher Channels API requires event data to be a JSON object. Passing a raw PHP string causes json_encode to produce a bare JSON string (e.g. "Test string"), which the API rejects with "Invalid JSON provided (could not parse)". Changed test data from 'Test string' to ['message' => 'Test string'] and renamed testStringPush to testEventPush to reflect what each test is actually asserting.
new HandlerStack() skips Guzzle's default middleware (including prepareBody), causing requests to be malformed and rejected by the API. Changed to HandlerStack::create() which includes the full default middleware stack while still allowing the custom increment middleware to be pushed on top.
Contributor
Author
|
Thanks @GrahamCampbell for the catch on |
aonemd
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.