Skip to content

Revert setting of --force-process-config… #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeeDeeG merged 1 commit into from
Dec 23, 2025
Merged

Revert setting of --force-process-config… #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,13 @@ class Command {
env.npm_config_disturl = config.getElectronUrl();
env.npm_config_arch = config.getElectronArch();
env.npm_config_target_arch = config.getElectronArch(); // for node-pre-gyp
env.npm_config_force_process_config = "true"; // for node-gyp
}
// node-gyp >=8.4.0 needs --force-process-config=true set for older Electron.
// For more details, see: https://github.com/nodejs/node-gyp/pull/2497,
// and also see the issues/PRs linked from that one for more context.

getNpmBuildFlags() {
return [`--target=${this.electronVersion}`, `--disturl=${config.getElectronUrl()}`, `--arch=${config.getElectronArch()}`, "--force-process-config"];
// We used to set `--force-process-config=true` here, but we've upgraded
// Electron past the point where that's needed. For more details, see:
// https://github.com/nodejs/node-gyp/pull/2497.
return [`--target=${this.electronVersion}`, `--disturl=${config.getElectronUrl()}`, `--arch=${config.getElectronArch()}`];
}

updateWindowsEnv(env) {
Expand Down