Skip to content

Fix ProUpServTx and ProRegTx serialization/deserialization#50

Merged
pshenmic merged 2 commits intopshenmic:developfrom
LexxXell:fixUpServ&UpReg
Feb 24, 2026
Merged

Fix ProUpServTx and ProRegTx serialization/deserialization#50
pshenmic merged 2 commits intopshenmic:developfrom
LexxXell:fixUpServ&UpReg

Conversation

@LexxXell
Copy link
Copy Markdown

  • Fixed ProUpServTx parsing for v1 (payloadSig as varbytes) and v2+ (raw 90/96 bytes).
  • Added support for optional platform fields in ProUpServTx (mn_type == 1).
  • Ensured correct cursor alignment to satisfy extraPayload size assertion.
  • Fixed ProRegTx payloadSig handling to consistently use varbytes (including empty signatures).
  • Removed incorrect fixed-length assumptions for ProRegTx signatures.

All related serialization tests now pass.

@pshenmic pshenmic merged commit 317650c into pshenmic:develop Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants