Fix injected particles again#391
Merged
JamesMcClung merged 2 commits intopsc-code:mainfrom Mar 25, 2026
Merged
Conversation
this was "fixed" previously, but that fix failed to consider that the prt position was used for getting the final/initial indices, which must be patch-local
JamesMcClung
force-pushed
the
pr/fix-inj-prt-pos
branch
from
9cbfd5e to
386c725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global vs patch-local positions struck again. Actually, it was the same strike as in #379, but now fixed (more) fully.
Also sneak in a change to the setup_particles random_offsets warning: only warn on proc 0.