Support randomized particle locations at t=0#389
Merged
JamesMcClung merged 11 commits intopsc-code:mainfrom Mar 23, 2026
Merged
Support randomized particle locations at t=0#389JamesMcClung merged 11 commits intopsc-code:mainfrom
JamesMcClung merged 11 commits intopsc-code:mainfrom
Conversation
so it doesn't have to be passed around
germasch
force-pushed
the
pr/randomize-prts
branch
from
17913f0 to
3b245dd
Compare
germasch
approved these changes
Mar 19, 2026
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
Looks great to me. I was going to suggest to test that one really ends up neutral, but then saw you added that already 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
random_offsetsboolean field toSetupParticles, which is false by default. When enabled, particles' initial positions are randomized within a cell instead of being centered. Locations of particles from different species are exactly correlated, so rho=0 as long as there is one positive and one negative species with equal densities. A warning is always emitted when this feature is used.Also add a test to check that rho=0 when random offsets are enabled.