Merged
Conversation
marder doesn't affect solenoidal part of E, so the order shouldn't affect physics
JamesMcClung
force-pushed
the
pr/polymorphic-marder
branch
from
a2fd4aa to
124b0df
Compare
Collaborator
Author
|
I have a few more changes that I plan to sneak into this PR, actually, but they'll have to wait until Tuesday. |
Collaborator
Author
As discussed: nevermind this, I'll submit a second PR with those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Marder correction polymorphic, too (under the more general term of "Gauss corrector").
Also generalize the implementation over dimension (possibly misguided), and do the correction before B (shouldn't actually matter).