Update cmake to gtensor minimum version#1
Merged
germasch merged 1 commit intopsc-code:mainfrom Mar 11, 2026
Merged
Conversation
gtensor recently updated to require 3.21 or higher, so just use that
Collaborator
Author
|
Also, while I'm pretty sure I identified the problem, I don't know if this is the full solution. TBD, I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The psc CI/CD recently stopped working (e.g. psc-code/psc#385) because it was using cmake version 3.20.2, whereas gtensor recently updated its cmake requirement to 3.21.
The problem seems to be that Docker is using a cached version of cmake. This repo (psc-infrastructure) was created May 8–14, 2021, which is exactly between the releases of cmake v3.20.2 and v3.20.3 (see here; the page may drift with time), which is consistent with cmake having been cached for the entire history of this repo.
To fix the CI/CD, it would probably suffice to just invalidate the cache (in any number of ways), but I take the approach of pinning the cmake version instead for the sake of clarity/transparency.
As an aside, here are some other links I came across while trying to figure out the CI/CD problem, included for posterity/future reference: