proposal: add proposal for label automation#66
proposal: add proposal for label automation#66jan--f wants to merge 1 commit intoprometheus:mainfrom
Conversation
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
label-automation
branch
from
85561d2 to
73de8da
Compare
jan--f
changed the title
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Looks great to me. I have, however, little experience with the existing K8s flows and don't know anything about Prow. It would be good if some other Prometheans with more experience in this regard could check this out before approving.
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
/lgtm
I guess the only problem is that Prometheus codebase is not entirely covered by the codeowners file?
My understanding is that we'll get that though. @gouthamve perhaps works on that? |
| ## Action Plan | ||
|
|
||
| * [ ] Review and accept this proposal | ||
| * [ ] Deploy prom-prow bot |
There was a problem hiding this comment.
I learned the hard way that testing things in prometheus/prometheus can be disruptive, let's do it in a test repo.
There was a problem hiding this comment.
I learned the hard way that testing things in prometheus/prometheus can be disruptive, let's do it in a test repo.
Yes indeed, I did a small test already on the repo mentioned in the proposal, e.g. https://github.com/jan--f/prom-prow/pull/1. But happy to do a larger scale test on a Prometheus clone as well.
4 participants
No description provided.