Skip to content

Feature/p8 sensor logger#233

Open
renereimann wants to merge 8 commits intodevelopfrom
feature/p8_sensor_logger
Open

Feature/p8 sensor logger#233
renereimann wants to merge 8 commits intodevelopfrom
feature/p8_sensor_logger

Conversation

@renereimann
Copy link
Contributor

Implementation of a sensor logger matching the database layout of project8.
The endpoint_name is used to check in the id_map table which type of data the endpoint is.
In a second step the correct table is selected and data are inserted.

@wcpettus
Copy link

wcpettus commented Mar 5, 2026

I attempted to tighten this by tweaking the base PostgresSensorLogger base class to add a bit of flexibility, then making a Mapped Logger class that could inherit expand on it (doing essentially the same thing). That lives over in dl-py:
driplineorg/dripline-python#223

My reasoning was:

  • ADMX and various P8 setups want something like this, so there's demand for the expansion
  • This method reduces code duplication for easier maintenance

Comments should follow of whether this was a good idea or not, but now the PRs are linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants