[NCL-9447] Define tracking-service API#331
Open
pkocandr wants to merge 2 commits intoproject-ncl:masterfrom
Open
[NCL-9447] Define tracking-service API#331pkocandr wants to merge 2 commits intoproject-ncl:masterfrom
pkocandr wants to merge 2 commits intoproject-ncl:masterfrom
Conversation
pkocandr
force-pushed
the
master
branch
4 times, most recently
from
626d31e to
1eec1f9
Compare
rnc
requested changes
Mar 26, 2026
Contributor
rnc
left a comment
rnc
left a comment
There was a problem hiding this comment.
Looks great. A few questions and one tiny comment :-)
| public class TrackedEntry extends TrackedArtifact implements Comparable<TrackedEntry> { | ||
|
|
||
| /** | ||
| * The original remote URL of the artifact. Empty in case the artifact was |
Contributor
There was a problem hiding this comment.
I think this sentence is missing the end?
|
|
||
| private String project; | ||
|
|
||
| private String name; |
Contributor
There was a problem hiding this comment.
Can we clarify how the artifact repositories will be laid out - for instance would it be
<project-key [ i.e. deployment e.g. pnc, pnc-devel, etc ]>-<buildType [maven | npm | etc]>-<repoType [ hosted | group(virtual) ]-build-<id>
Maybe repoType isn't required?
Should build type be included?
e.g.
pnc-maven-build-1234
| * The identifier of the repository where the artifact is located. | ||
| */ | ||
| @EqualsAndHashCode.Include | ||
| private final RepositoryId repoId; |
Contributor
There was a problem hiding this comment.
Question - does the artifact need to record the type of the repository e.g. maven, npm, etc? Or should that be part of repository? (if needed at all)...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.