Remove keycloak id from user model#629
Open
thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
Open
Remove keycloak id from user model#629thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
thescouser89 wants to merge 1 commit intoproject-ncl:masterfrom
Conversation
1 task
The keycloak id is present in the user model to guarantee uniqueness. However, it is also pretty much guaranteed that the username will uniquely identify a single user only. The other reason why this commit removes the keycloak id is because we need to support other ways of authentication (LDAP). LDAP doesn't provide such a keycloak id (but in theory we could use a unique ID from the LDAP entry for the user). However the same user authenticating through LDAP and then through OIDC would be considered 2 different 'persons' because of the different ids. I believe it would be much easier to just use the username to uniquely identify a user as a result.
thescouser89
force-pushed
the
quarkus-drop-user-id
branch
from
ee40d52 to
cab5932
Compare
rnc
approved these changes
Mar 25, 2026
Contributor
rnc
left a comment
rnc
left a comment
There was a problem hiding this comment.
Looks fine to me - one question - would this cause any issues with existing tables?
Contributor
Author
|
@rnc I think it'll cause issues for the existing NotNull annotation that might set that constraint at the db level. We'll have to remove it post-deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keycloak id is present in the user model to guarantee uniqueness. However, it is also pretty much guaranteed that the username will uniquely identify a single user only.
The other reason why this commit removes the keycloak id is because we need to support other ways of authentication (LDAP). LDAP doesn't provide such a keycloak id (but in theory we could use a unique ID from the LDAP entry for the user). However the same user authenticating through LDAP and then through OIDC would be considered 2 different 'persons' because of the different ids.
I believe it would be much easier to just use the username to uniquely identify a user as a result.
Checklist: