Open
Conversation
Idée : 🏋🫖☠prixe#1
Kedaostram
reviewed
Feb 12, 2022
Kedaostram
left a comment
Kedaostram
left a comment
There was a problem hiding this comment.
Hello, quelques remarques pour essayer de rendre le code moins répétitif, et enlever les choses inutiles !
Comment on lines
+4
to
+5
| private Zaap; | ||
| private DivList = [] |
Author
There was a problem hiding this comment.
Merci pour t'est commentaire,
tu as recrée un compte Discord ? si oui mp KeyTur#4671
Author
There was a problem hiding this comment.
ok tu me dira si tu revien dessus,
On a crée un discord privé pour l'instant
Comment on lines
+21
to
+59
| private getZaap(e){ | ||
| const Zaap = this.wGame.gui.windowsContainer.getChildren().find(e=>e.id=="teleporterList") | ||
| const ZaapList = Zaap.zaapBody.panelCollection.Zaap.table.content._childrenList | ||
| const PrismList = Zaap.zaapBody.panelCollection.Prism.table.content._childrenList | ||
| for (var i = 0; i < ZaapList.length - 1; i++) { | ||
| this.DivList.push(ZaapList[i].rootElement) | ||
| } | ||
| for (var i = 0; i < PrismList.length - 1; i++) { | ||
| this.DivList.push(PrismList[i].rootElement) | ||
| } | ||
| this.DivList.forEach(element => { | ||
| element.addEventListener('dblclick', () => { Zaap.windowBody._childrenList.find(e => e.rootElement?.classList?.contains('footer'))._childrenList[0].tap(); }) | ||
| }) | ||
| } | ||
|
|
||
|
|
||
|
|
||
| private getZaapiPrism(e){ | ||
| const Zaapi = this.wGame.gui.windowsContainer.getChildren().find(e=>e.id=="teleporterList") | ||
| const ZaapiListC = Zaapi.subwayBody.panelCollection.CraftHouse.table.content._childrenList | ||
| const ZaapiListB = Zaapi.subwayBody.panelCollection.BidHouse.table.content._childrenList | ||
| const ZaapiListM = Zaapi.subwayBody.panelCollection.Misc.table.content._childrenList | ||
| if(e.teleporterType === 1){ | ||
| for (var i = 0; i < ZaapiListC.length - 1; i++) { | ||
| this.DivList.push(ZaapiListC[i].rootElement) | ||
| } | ||
| for (var i = 0; i < ZaapiListB.length - 1; i++) { | ||
| this.DivList.push(ZaapiListB[i].rootElement) | ||
| } | ||
| for (var i = 0; i < ZaapiListM.length - 1; i++) { | ||
| this.DivList.push(ZaapiListM[i].rootElement) | ||
| } | ||
| this.DivList.forEach(element => { | ||
| element.addEventListener('dblclick', () => { Zaapi.windowBody._childrenList.find(e => e.rootElement?.classList?.contains('footer'))._childrenList[0].tap(); }) | ||
| }) | ||
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
Tu peux fusionner tes fonctions getZaapiPrism() et getZaap() en 1 seule avec une simple condition if/else
if (e.teleporterType == 1) {
// Craft/Bid/Misc
} else {
// Zaap/Zaapi
}Cette fonction ainsi créée peut retourner directement la liste des zaap, et t'as plus qu'à boucler dessus.
| this.DivList.push(PrismList[i].rootElement) | ||
| } | ||
| this.DivList.forEach(element => { | ||
| element.addEventListener('dblclick', () => { Zaap.windowBody._childrenList.find(e => e.rootElement?.classList?.contains('footer'))._childrenList[0].tap(); }) |
There was a problem hiding this comment.
Tu devrais ajouter un délai entre le double clic et le OK, histoire de pas le faire instantanément.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idée : 🏋🫖☠#1
Script fonctionelle mais si vous avez des idées d'optimisation ( Keda 😶) ca sera pas plus mal