Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

Add support for custom DISTRIBUTION metric#3

Merged
cpiemontese merged 1 commit intofeature/switch_from_configfrom
add-support-for-custom-distribution-metric
Sep 29, 2022
Merged

Add support for custom DISTRIBUTION metric#3
cpiemontese merged 1 commit intofeature/switch_from_configfrom
add-support-for-custom-distribution-metric

Conversation

@macciomauro
Copy link

@macciomauro macciomauro commented Sep 16, 2022 •
edited
Loading

Enable DataDog distribution metric

This PR is copied from lexmag#54 but based on feature/switch_from_config branch

This feature unlock the possibility to have more specific metrics with percentiles calculations

⚠️ I think we need to think how to maintain this feature incrementing on Statix fork. I don't think we really wanna merge this PR on feature/switch_from_config branch ⚠️

test_distribution

The usage is the same of timing metrics

MyApp.Datadog.distribution(
          "my.metric.name",
          "123456789",
          tags: [ ]
        )

When the metric is displayed on DataDog we need to enable percentiles on Mentrics summary

metric_summary

Rechyrex
Rechyrex approved these changes Sep 19, 2022
View reviewed changes
Copy link

@Rechyrex Rechyrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look to the other PR and it looks good to me, but I do not have that much context on statix 👀 Probably better to wait for at least one other review

@macciomauro
Copy link
Author

macciomauro commented Sep 21, 2022

what can be the next steps to take it forward? more for the merge approach

@cpiemontese cpiemontese merged commit cd3e635 into feature/switch_from_config Sep 29, 2022
@cpiemontese cpiemontese deleted the add-support-for-custom-distribution-metric branch September 29, 2022 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pdincau pdincau Awaiting requested review from pdincau

@cpiemontese cpiemontese Awaiting requested review from cpiemontese

@matteosister matteosister Awaiting requested review from matteosister

@cottinisimone cottinisimone Awaiting requested review from cottinisimone

2 more reviewers

@mbusi mbusi mbusi approved these changes

@Rechyrex Rechyrex Rechyrex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macciomauro @mbusi @Rechyrex @cpiemontese