Improve encoding detection of the XML TV file#36
Open
thombet wants to merge 1 commit intoprimaeval:masterfrom
Open
Improve encoding detection of the XML TV file#36thombet wants to merge 1 commit intoprimaeval:masterfrom
thombet wants to merge 1 commit intoprimaeval:masterfrom
Conversation
The encoding of the XML TV file can be found either: 1. with a regular expression on the encoding tag in the XML file 2. or using the chardet.detect() function on the content of the XML file Option 1 is improved by updating the regex: an encoding tag using single quotes will also be detected now. Option 2 could last more than several minutes for huge files. So if the file has more than 50,000 characters, the detection is done only on the first 50,000 characters (which should be enough to detect the encoding).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoding of the XML TV file can be found either:
Option 1 is improved by updating the regex: an encoding tag using
single quotes will also be detected now.
Option 2 could last more than several minutes for huge files. So if the
file has more than 50,000 characters, the detection is done only on the
first 50,000 characters (which should be enough to detect the encoding).