Add Enhanced Ingestion Mode to genddl Tool#85
Open
ron-daniel1 wants to merge 4 commits intoprestodb:mainfrom
Open
Add Enhanced Ingestion Mode to genddl Tool#85ron-daniel1 wants to merge 4 commits intoprestodb:mainfrom
ron-daniel1 wants to merge 4 commits intoprestodb:mainfrom
Conversation
If source file format is TEXTFILE then insert can be completed without CAST. Schema creation for target table has a syntax error now fixed. The sql files are created for the specified schema and catalog and not for every table combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds enhanced ingestion mode to cmd/genddl for generating TPC-DS data
ingestion SQL files.
Key Features:
Files Changed:
New Templates:
Modified: main.go
Schema struct additions:
New functions:
Modified functions:
(iceberg=true → Iceberg only) instead of all 4 variants
based on mode
Modified: insert_table.sql.tmpl
Testing:
✅ All 10 tests pass
✅ Backward compatible - legacy mode unchanged
✅ Generated examples match golden files
Usage:
Enhanced:
go run main.go genddl config_enhanced_ingestion.jsonLegacy:
go run main.go genddl config.json(unchanged)