test: add unit tests for state and git lib modules#76
Closed
TerminalGravity wants to merge 1 commit intomainfrom
Closed
test: add unit tests for state and git lib modules#76TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
- 10 tests for state.ts: loadState, saveState, appendLog, readLog, now() - 8 tests for git.ts: getBranch, getStatus, commits, staged files, error handling - Coverage goes from 43 to 61 tests (42% increase)
Collaborator
Author
|
CI fails because the git lib test creates commits but the runner has no git identity. Need to add |
Collaborator
Author
|
CI is failing — the git tests need Fix: add a setup step in the test (or in CI) to configure a dummy git identity: beforeAll(() => {
execSync('git config user.name "Test" && git config user.email "test@test.com"', { cwd: tmpDir });
});Or add it to the CI workflow before |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 18 new unit tests covering two previously untested lib modules.
state.ts (10 tests): loadState, saveState, appendLog/readLog, now()
git.ts (8 tests): getBranch, getStatus, commits, staged files, error handling
Test count: 43 → 61. All green.