test: add 18 unit tests for prompt_score scoring logic#131
Open
TerminalGravity wants to merge 1 commit intomainfrom
Open
test: add 18 unit tests for prompt_score scoring logic#131TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
TerminalGravity
commented
Mar 6, 2026
Collaborator
Author
TerminalGravity
left a comment
TerminalGravity
left a comment
There was a problem hiding this comment.
Nice test suite. Good mix of high/medium/low quality prompt scenarios and edge cases. The export of scorePrompt and ScoreResult is the right call for testability. Ready to merge.
- Export scorePrompt function for testability - Test all 4 scoring dimensions (specificity, scope, actionability, done condition) - Test grading thresholds (A+ through F) - Test feedback generation for low and high scores - First tool-level test file (tests/tools/ directory) Increases test count from 43 to 61.
TerminalGravity
force-pushed
the
test/prompt-score-unit-tests
branch
from
97fd590 to
1f0ce28
Compare
TerminalGravity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First tool-level tests — covers all 4 scoring dimensions, grading, and feedback for
scorePrompt. Exports the function for testability. Test count: 43 → 61.