Add Soroban contracts: PredicateRegistry, test stablecoin, and client library#54
Closed
alex-predicate wants to merge 16 commits intomainfrom
Closed
Add Soroban contracts: PredicateRegistry, test stablecoin, and client library#54alex-predicate wants to merge 16 commits intomainfrom
alex-predicate wants to merge 16 commits intomainfrom
Conversation
Design document for adding Soroban (Stellar) smart contracts: predicate-registry, test-stablecoin, and predicate-client library. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7-task plan covering workspace scaffolding, predicate-client types, predicate-registry contract, test-stablecoin, integration tests, CI/CD updates, and final verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cargo workspace with predicate-client (rlib), predicate-registry (cdylib), and test-stablecoin (cdylib). All compile against soroban-sdk 25.3.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Implement the PredicateRegistry Soroban contract, porting the EVM PredicateRegistry.sol. Includes initialization, ownership transfer, attester management (register/deregister with swap-and-pop), policy management, Ed25519 attestation validation with replay protection, and TTL extension. All 18 tests pass including full Ed25519 signing round-trip between ed25519-dalek and soroban-sdk. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds test_authorize_transaction_integration to the predicate-registry test module. A TestWrapperContract is deployed so that authorize_transaction runs in a real contract context, setting target = wrapper address and making a cross-contract call to validate_attestation on the registry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- contracts.yml: new soroban-build job (Rust, stellar-cli, build, test, fmt) - publish.yml: Soroban WASM build + placeholder publish commands Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Auto-generated JSON files that add ~8k lines of noise to the diff. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PredicateRegistry.sol: attester management, policy binding, Ed25519 attestation validation with UUID replay protection and expiration checksFungibleToken+BlockList+FungibleBurnable+AccessControl)Statement/Attestationtypes,serialize_statement, andauthorize_transactioncross-contract helpersoroban-buildjob tocontracts.ymland Soroban WASM publishing placeholders topublish.yml36 Soroban tests passing. All 41 existing EVM tests unaffected.
Notable decisions
soroban-sdk 23.5.3while registry/client use25.3.0— the crates are independent so this coexists cleanlyenv.crypto().ed25519_verify()targetfield bound to calling contract's address viaenv.current_contract_address()Test plan
cd soroban && cargo test— 36 tests across 4 cratescd soroban && cargo fmt --check— formatting cleanforge test— 41 EVM tests still passPredicateRegistry.sol🤖 Generated with Claude Code