Open
Conversation
kkovacs
commented
May 19, 2022
|
|
||
| assert not self.isInsideGroup(), 'Invalid syntax' | ||
| raise StopIteration | ||
| # raise StopIteration # XXX I'm not too confident of the purpose of this, but it works without it. |
Author
There was a problem hiding this comment.
If you could look at this one line, that would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Vsevolod!!
I'm using your great bash minifier regularly, but I ran into problems now that python2 is deprecated FOR REAL.
I made the changes that were needed to run on python3, and I thought I'd contribute back. There is one change I'm not completely sure about (although it work like this and all the tests ran), maybe you could review it.
Have a great day! :)
Kristof