Skip to content

Add pybind11 to dockerfile for system test#737

Open
Fujikawas wants to merge 4 commits intodevelopfrom
dockerdumux
Open

Add pybind11 to dockerfile for system test#737
Fujikawas wants to merge 4 commits intodevelopfrom
dockerdumux

Conversation

@Fujikawas
Copy link
Member

According to #696 (comment), the micro-manager participant in two-scale-heat-conduction case depends on pybind11.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@Fujikawas Fujikawas self-assigned this Mar 2, 2026
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pybind11 is technically a dependency of micro-dumux, and not of the adapter. Could we install it right before the participant micro-dumux is compiled?

@Fujikawas
Copy link
Member Author

pybind11 is technically a dependency of micro-dumux, and not of the adapter. Could we install it right before the participant micro-dumux is compiled?

You are right. As pybind11 is also not an independent component that we would test etc. like the other adapters/MM, I'd tend to merge it into the installation of Micro Manager since it's often used between C++ case and MM. Also I would like to base the dumux-adapter on preCICE instead of MM.

@IshaanDesai
Copy link
Member

You are right. As pybind11 is also not an independent component that we would test etc. like the other adapters/MM, I'd tend to merge it into the installation of Micro Manager since it's often used between C++ case and MM. Also I would like to base the dumux-adapter on preCICE instead of MM.

Makes sense! Let's trigger the system test from this PR once the changes are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants