systemtests: add heat-exchanger-simplified test suite#731
Open
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
Open
systemtests: add heat-exchanger-simplified test suite#731AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
AdityaGupta716 wants to merge 2 commits intoprecice:developfrom
Conversation
Collaborator
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-aditya-gupta/2773/2 |
25 tasks
cfc73eb to
3225a04
Compare
Add heat-exchanger-simplified to the system test suites, covering the fluid-top-openfoam, fluid-btm-openfoam, solid-calculix case combination.
3225a04 to
4fab16a
Compare
Author
|
@makis, would love your feedback while adding the test suite I ran into a few things locally Ubuntu 24.04 has a default user with UID/GID 1000 which breaks the container build, some adapter ARGs were missing defaults which caused issues when building standalone, and the CalculiX and SU2 downloads occasionally fail without retries. Fixed all of those along the way. Let me know if anything needs changing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
heat-exchanger-simplifiedto the system test suites intools/tests/tests.yamlas both a new standalone suiteheat_exchanger_simplified_testand as an entry in the existingrelease_testsuite.Also fixes several Docker and Ubuntu 24.04 compatibility issues that prevented local system test runs.
Changes
tests.yaml
heat_exchanger_simplified_teststandalone suite with case(fluid-top-openfoam, fluid-btm-openfoam, solid-calculix)release_testso it runs in release CISystemtest.py
_get_docker_compose_cmd()to auto-detectdocker composevsdocker-composedocker compose --filePopen calls to use the detection helper with-fDockerfile (ubuntu_2404)
userdel -r ubuntubefore creatingpreciceuser, removing the default Ubuntu 24.04 user including its home directory — cleaner fix for the UID/GID 1000 conflict=masterdefaults for all six adapter ARGs:OPENFOAM_ADAPTER_REF,PYTHON_BINDINGS_REF,FENICS_ADAPTER_REF,CALCULIX_ADAPTER_REF,SU2_ADAPTER_REF,DEALII_ADAPTER_REF--tries=3 --retry-connrefused --timeout=30to wget for both CalculiX and SU2 downloadscomponents.yaml
PYTHON_BINDINGS_REFto calculix-adapter build argsVerification
heat-exchanger-simplifiedhas a completemetadata.yamlwith all required participants and casesmetadata.yamlpython3 print_test_suites.py— bothheat_exchanger_simplified_testandrelease_testshow the new tutorialpython3 systemtests.py --suites=heat_exchanger_simplified_test --build_args=TUTORIALS_REF:develop— Docker images build and coupled run completes; fails only at field-comparison due to missing reference archive (expected)Notes on reference results
Reference results for heat-exchanger-simplified will need to be generated on a Linux machine via CI or
generate_reference_results.py. The.gitkeepplaceholder has been added toheat-exchanger-simplified/reference-results/.Checklist
changelog-entries/731.md