Make the get-latest-components workflow conditional.#723
Make the get-latest-components workflow conditional.#723kishansinghifs1 wants to merge 2 commits intoprecice:developfrom
Conversation
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-kishan-singh-system-tests-improvements/2775/1 |
MakisH
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
The conditional check already worked in this PR.
I am not sure if passing the GITHUB_TOKEN would be the right approach here. In #682, the suggestion was for an app id, which we would need to set up.
Let's split this into two. Please remove the authentication aspects, and we see if that's enough. I think it will be.
Btw, I renamed the PR, please rename again after removing the authentication aspects.
|
Hiii @MakisH I was initially thinking of the same but now as you clarified it would be more helpful to me.I'll apply those changes and let you know soon. Thanks for the review!!!!!!!! |
|
Hi @MakisH I removed the authentication spec and now you can cleanly merge this . Thank you !!!!! |
|
Already committed cleanly #733 we can close this PR as duplicate. |
Fix #682 - Part 1
if: ${{ github.event.label.name == 'trigger-system-tests' }}Checklist:
changelog-entries/<PRnumber>.md.