feat: Improve handling of database drivers with missing dependencies#779
Merged
feat: Improve handling of database drivers with missing dependencies#779
Conversation
Instead of catching the exception during import of the database driver, change the behavior to let the `ImportError` exception propagate. This allow to lazy-import the drivers and gracefully handle the missing dependencies during the configuration.
Lazily import the database drivers inside the factory methods in order to gracefully handles failures because of missing dependencies.
- Split the generator tests for databases with external dependencies - Use builtin database drivers (csv, socket, json) for generic tests - Update test configuration files - Remove unused fixtures
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
==========================================
+ Coverage 69.88% 70.28% +0.40%
==========================================
Files 91 91
Lines 2919 2908 -11
==========================================
+ Hits 2040 2044 +4
+ Misses 879 864 -15
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves how database drivers with missing external dependencies are handled.
Detailed changes :
ImportErrorpropagate from database drivers.powerapi.databasemodule.