Open
Conversation
1. function naming 2. removing logic that perform duplicate process 3. separating fuction into units of same feature
1. function naming 2. removing logic that perform same process 3. separating fuction into units of same feature
1. ui code, xml databinding refactoring 2. remove duplicated code
suspand fun -> flow를 리턴하도록 변경
flow로 변경
BaseFragment를 용도에 맞게 짬뽕코드 다 분리하여 리팩토링
ImageUploadViewModel을 ImageUploadFragment, ImageResultFragment가 공유하며 생긴 의존성 문제 해결
노트 내용을 추가하며 링크 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README 내용 보완