Hide irrelevant upstream notebook commands in Positron notebooks#12637
Open
Hide irrelevant upstream notebook commands in Positron notebooks#12637
Conversation
Made-with: Cursor
|
E2E Tests 🚀 |
Contributor
|
This looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #10481.
Hides upstream VS Code notebook commands (developer troubleshooting, layout configuration, sticky scroll, etc.) from the command palette when the Positron notebook editor is active. These commands target the upstream notebook implementation and don't apply to Positron notebooks.
Introduces a shared
POSITRON_NOTEBOOK_IS_NOT_ACTIVE_EDITORcontext key expression used as aprecondition(forf1: truecommands) orwhenclause (for explicitMenuId.CommandPaletteentries) to gate visibility. Also replaces a hard-coded editor ID string in ghost cell actions with thePOSITRON_NOTEBOOK_EDITOR_IDconstant.Before changes (note developer commands etc.)
After changes
Release Notes
New Features
Bug Fixes
QA Notes
@:notebooks @:positron-notebooks
.ipynbfile in the Positron notebook editor.ipynbin the standard VS Code notebook editor (disable Positron notebook) and verify those commands do appear