Skip to content

Replace 'Show hidden output' with muted 'Output collapsed'#12580

Open
seeM wants to merge 1 commit intomainfrom
feat/collapsed-output-label
Open

Replace 'Show hidden output' with muted 'Output collapsed'#12580
seeM wants to merge 1 commit intomainfrom
feat/collapsed-output-label

Conversation

@seeM
Copy link
Contributor

@seeM seeM commented Mar 18, 2026

This PR reworks the 'Show hidden output' button given the new collapse toggle:

  • Reworded to 'Output collapsed'
  • Monospace font - it feels more comfortable to see monospace in cell outputs since 90% of text outputs will be monospace
  • More muted styling
Screen.Recording.2026-03-19.at.09.55.29.mov

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@:web @:positron-notebooks

@seeM seeM requested review from dhruvisompura and nstrayer March 18, 2026 16:16
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:web @:positron-notebooks

readme  valid tags

@seeM seeM force-pushed the feat/collapsed-output-label branch from 38ca67b to bce6d05 Compare March 19, 2026 07:44
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from 6bbdc84 to 1c9c140 Compare March 19, 2026 08:32
@seeM seeM force-pushed the feat/collapsed-output-label branch 2 times, most recently from cdd8f51 to a7e8b6d Compare March 19, 2026 12:55
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from 9941818 to a5b0828 Compare March 19, 2026 13:01
@seeM seeM force-pushed the feat/collapsed-output-label branch from a7e8b6d to 4f8b3ff Compare March 19, 2026 13:01
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from a5b0828 to 0f6f9f1 Compare March 19, 2026 14:04
@seeM seeM force-pushed the feat/collapsed-output-label branch from 536088e to d485d8f Compare March 19, 2026 14:05
nstrayer
nstrayer previously approved these changes Mar 19, 2026
Copy link
Contributor

@nstrayer nstrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin!

Image

One note: I found it a bit odd that the tooltip effectively is the opposite of the element it's tooltipping for. I wonder if it could (should) be more descriptive. Like "Click to expand output" or something.

@seeM seeM force-pushed the feat/cell-output-collapse-button branch from 0f6f9f1 to ba0f3b9 Compare March 19, 2026 15:42
@seeM seeM force-pushed the feat/collapsed-output-label branch from d485d8f to ddd2878 Compare March 19, 2026 15:44
@seeM
Copy link
Contributor Author

seeM commented Mar 19, 2026

True it is strange, I like your suggestion will fix

@seeM seeM force-pushed the feat/collapsed-output-label branch from ddd2878 to fae71b0 Compare March 19, 2026 16:11
@seeM seeM force-pushed the feat/cell-output-collapse-button branch 2 times, most recently from 69c6827 to a19265a Compare March 19, 2026 16:15
@seeM seeM force-pushed the feat/collapsed-output-label branch 2 times, most recently from 65913c4 to 36f7a37 Compare March 19, 2026 16:45
Copy link
Contributor

@dhruvisompura dhruvisompura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and they worked as expected but I am a little worried about the new muted button style. The default style doesn't give the user any indication that they can click on the button to expand the output unless you hover over it and that is unlikely when the text just says "Output collapsed" - which indicated the current state.

If we really want to keep the muted style, we should change the text to be a "call to action" so the user knows to click on it (e.g. "Show output", "Click to expand output", etc)

@seeM seeM force-pushed the feat/cell-output-collapse-button branch from a19265a to 8d329aa Compare March 20, 2026 09:02
@seeM seeM force-pushed the feat/collapsed-output-label branch from 36f7a37 to 3582129 Compare March 20, 2026 09:02
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from 8d329aa to c1526bd Compare March 20, 2026 10:17
@seeM seeM force-pushed the feat/collapsed-output-label branch from 3582129 to 6eddb62 Compare March 20, 2026 10:17
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from c1526bd to 88eee6c Compare March 20, 2026 10:44
@seeM seeM force-pushed the feat/collapsed-output-label branch from 6eddb62 to 089d8de Compare March 20, 2026 10:44
@seeM
Copy link
Contributor Author

seeM commented Mar 20, 2026

It is intentionally less emphasized than before (shorter text and more neutral color) because that also makes it less distracting, which is what a user wants when they choose to collapse it. That is the issue I was trying to address.

I agree that this change also makes it less clear that it's clickable, but since it's one of three ways to expand an output I'd rather let it be less distracting and sacrifice the discoverability.

In other words, the clickability is a nice bonus but not the primary purpose of the component nor the primary way to expand an output.

IMO the best thing to put in this spot would be a one-line preview of the collapsed output, but that's quite a lot more work to cover all the various output types and combinations.

@seeM seeM force-pushed the feat/collapsed-output-label branch from 089d8de to bead6bc Compare March 20, 2026 13:22
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from 88eee6c to fe0095e Compare March 20, 2026 13:22
@seeM seeM force-pushed the feat/collapsed-output-label branch from bead6bc to 43e2d13 Compare March 20, 2026 13:25
@seeM seeM force-pushed the feat/cell-output-collapse-button branch from fe0095e to 9cd99d3 Compare March 20, 2026 16:14
Base automatically changed from feat/cell-output-collapse-button to main March 20, 2026 16:15
@seeM seeM dismissed nstrayer’s stale review March 20, 2026 16:15

The base branch was changed.

…d' label

Replace the prominent "Show hidden output" button with a subtle, italic
"Output collapsed" label using the Button component for VS Code-style
tooltips. Uses descriptionForeground for accessible contrast and
inherits monospace font from the outputs container.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ghstack-source-id: 657077e
Pull-Request: #12629
@seeM seeM force-pushed the feat/collapsed-output-label branch from 43e2d13 to 8417dea Compare March 20, 2026 16:24
@seeM seeM requested a review from dhruvisompura March 20, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants