Replace 'Show hidden output' with muted 'Output collapsed'#12580
Replace 'Show hidden output' with muted 'Output collapsed'#12580
Conversation
|
E2E Tests 🚀 |
38ca67b to
bce6d05
Compare
6bbdc84 to
1c9c140
Compare
cdd8f51 to
a7e8b6d
Compare
9941818 to
a5b0828
Compare
a7e8b6d to
4f8b3ff
Compare
a5b0828 to
0f6f9f1
Compare
536088e to
d485d8f
Compare
0f6f9f1 to
ba0f3b9
Compare
d485d8f to
ddd2878
Compare
|
True it is strange, I like your suggestion will fix |
ddd2878 to
fae71b0
Compare
69c6827 to
a19265a
Compare
65913c4 to
36f7a37
Compare
dhruvisompura
left a comment
There was a problem hiding this comment.
I tested the changes and they worked as expected but I am a little worried about the new muted button style. The default style doesn't give the user any indication that they can click on the button to expand the output unless you hover over it and that is unlikely when the text just says "Output collapsed" - which indicated the current state.
If we really want to keep the muted style, we should change the text to be a "call to action" so the user knows to click on it (e.g. "Show output", "Click to expand output", etc)
a19265a to
8d329aa
Compare
36f7a37 to
3582129
Compare
8d329aa to
c1526bd
Compare
3582129 to
6eddb62
Compare
c1526bd to
88eee6c
Compare
6eddb62 to
089d8de
Compare
|
It is intentionally less emphasized than before (shorter text and more neutral color) because that also makes it less distracting, which is what a user wants when they choose to collapse it. That is the issue I was trying to address. I agree that this change also makes it less clear that it's clickable, but since it's one of three ways to expand an output I'd rather let it be less distracting and sacrifice the discoverability. In other words, the clickability is a nice bonus but not the primary purpose of the component nor the primary way to expand an output. IMO the best thing to put in this spot would be a one-line preview of the collapsed output, but that's quite a lot more work to cover all the various output types and combinations. |
089d8de to
bead6bc
Compare
88eee6c to
fe0095e
Compare
bead6bc to
43e2d13
Compare
fe0095e to
9cd99d3
Compare
…d' label Replace the prominent "Show hidden output" button with a subtle, italic "Output collapsed" label using the Button component for VS Code-style tooltips. Uses descriptionForeground for accessible contrast and inherits monospace font from the outputs container. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> ghstack-source-id: 657077e Pull-Request: #12629
43e2d13 to
8417dea
Compare

This PR reworks the 'Show hidden output' button given the new collapse toggle:
Screen.Recording.2026-03-19.at.09.55.29.mov
Release Notes
New Features
Bug Fixes
QA Notes
@:web @:positron-notebooks