E2E tests: drag-and-drop notebook cell reordering#12328
Draft
rodrigosf672 wants to merge 1 commit intomainfrom
Draft
E2E tests: drag-and-drop notebook cell reordering#12328rodrigosf672 wants to merge 1 commit intomainfrom
rodrigosf672 wants to merge 1 commit intomainfrom
Conversation
|
E2E Tests 🚀 |
Extend notebook-cell-reordering.test.ts with comprehensive drag-and-drop tests for issue #9840. Adds 8 new tests covering single/multi-cell dragging, boundary cases, auto-scroll, escape cancellation, and undo/redo. Also adds dragCellToCell() helper method to notebooksPositron page object. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
0b561ce to
7bff8f8
Compare
Member
Author
|
@rodrigosf672 draft for now, wait for clarifications and full implementation of #9840 to be settled so that changes to PR can be made for drag and drop tests to be automated (to catch potential breakages with that in the future). |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the existing
notebook-cell-reordering.test.tssuite with comprehensive drag-and-drop tests for issue #9840.test.stepfor clear organization with succinct assertionsdragCellToCell()helper method to page object with smart fallback selectorsTest Coverage
Existing tests (keyboard/action bar reordering):
New drag-and-drop tests:
Test Plan
These tests are designed to run once the drag-and-drop feature is implemented. The
dragCellToCell()helper includes fallback logic to adapt to the actual implementation:.cell-drag-handle(expected per issue spec).cell-gutteror.positron-notebook-code-cell-gutter