fix(deps): update macadam.js to 0.7.0#2432
fix(deps): update macadam.js to 0.7.0#2432cdrage wants to merge 1 commit intopodman-desktop:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
### What does this PR do? Updates `@crc-org/macadam.js` to `0.7.0` includes the upstream fix for `areBinariesAvailable()` for Linux. I also noticed there is a difference between frontend and backend... it should be the same dependency. ### What issues does this PR fix or reference? Ref: crc-org/macadam.js#146 Closes podman-desktop#2331 ### How to test this PR? 1. On a Linux machine, ensure macadam is not installed (`whereis macadam` should return nothing) 2. Build and install this extension (or run through `pnpm watch`) 4. Confirm no ENOENT errors in the console on startup Signed-off-by: Charlie Drage <charlie@charliedrage.com>
8b6b320 to
e6682b8
Compare
| }, | ||
| "dependencies": { | ||
| "@crc-org/macadam.js": "0.6.0", | ||
| "@crc-org/macadam.js": "0.7.0-next.202604010134-27d76e8", |
There was a problem hiding this comment.
FYI using -next for others to test this PR, otherwise, we should wait for 0.7.0 to come out @feloy
fix(deps): update macadam.js to 0.7.0
What does this PR do?
Updates
@crc-org/macadam.jsto0.7.0includes the upstream fix for
areBinariesAvailable()for Linux.I also noticed there is a difference between frontend and backend... it
should be the same dependency.
What issues does this PR fix or reference?
Ref: crc-org/macadam.js#146
Closes #2331
How to test this PR?
(
whereis macadamshould return nothing)pnpm watch)Signed-off-by: Charlie Drage charlie@charliedrage.com