Skip to content

fix(deps): update macadam.js to 0.7.0#2432

Draft
cdrage wants to merge 1 commit intopodman-desktop:mainfrom
cdrage:fix-macadam-issue-binary
Draft

fix(deps): update macadam.js to 0.7.0#2432
cdrage wants to merge 1 commit intopodman-desktop:mainfrom
cdrage:fix-macadam-issue-binary

Conversation

@cdrage
Copy link
Copy Markdown
Contributor

@cdrage cdrage commented Apr 2, 2026

fix(deps): update macadam.js to 0.7.0

What does this PR do?

Updates @crc-org/macadam.js to 0.7.0
includes the upstream fix for areBinariesAvailable() for Linux.

I also noticed there is a difference between frontend and backend... it
should be the same dependency.

What issues does this PR fix or reference?

Ref: crc-org/macadam.js#146

Closes #2331

How to test this PR?

  1. On a Linux machine, ensure macadam is not installed
    (whereis macadam should return nothing)
  2. Build and install this extension (or run through pnpm watch)
  3. Confirm no ENOENT errors in the console on startup

Signed-off-by: Charlie Drage charlie@charliedrage.com

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 20892b91-8326-4982-aad9-f5341f42b610

📥 Commits

Reviewing files that changed from the base of the PR and between 8b6b320 and e6682b8.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages/backend/package.json
  • packages/frontend/package.json
✅ Files skipped from review due to trivial changes (2)
  • packages/frontend/package.json
  • packages/backend/package.json

📝 Walkthrough

Walkthrough

Updated @crc-org/macadam.js dependency to 0.7.0-next.202604010134-27d76e8 in both backend and frontend package manifests; no other package metadata or source files changed.

Changes

Cohort / File(s) Summary
Macadam.js Dependency Updates
packages/backend/package.json, packages/frontend/package.json
Bumped @crc-org/macadam.js to 0.7.0-next.202604010134-27d76e8 in both packages; no other dependencies, scripts, or metadata modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: updating the macadam.js dependency to version 0.7.0, which is the primary objective of this PR.
Description check ✅ Passed The description provides relevant context about the dependency update, references the upstream fix for areBinariesAvailable() on Linux, and includes testing instructions that align with the changeset.
Linked Issues check ✅ Passed The PR updates @crc-org/macadam.js to 0.7.0 which includes the upstream fix for areBinariesAvailable() on Linux, directly addressing issue #2331's requirement to better handle macadam availability checks and prevent spawn ENOENT errors.
Out of Scope Changes check ✅ Passed The PR only updates dependency versions in package.json files for both frontend and backend, which is directly aligned with the stated objective to fix the macadam availability issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

### What does this PR do?

Updates `@crc-org/macadam.js` to `0.7.0`
includes the upstream fix for `areBinariesAvailable()` for Linux.

I also noticed there is a difference between frontend and backend... it
should be the same dependency.

### What issues does this PR fix or reference?

Ref: crc-org/macadam.js#146

Closes podman-desktop#2331

### How to test this PR?

1. On a Linux machine, ensure macadam is not installed
   (`whereis macadam` should return nothing)
2. Build and install this extension (or run through `pnpm watch`)
4. Confirm no ENOENT errors in the console on startup

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage force-pushed the fix-macadam-issue-binary branch from 8b6b320 to e6682b8 Compare April 2, 2026 20:32
},
"dependencies": {
"@crc-org/macadam.js": "0.6.0",
"@crc-org/macadam.js": "0.7.0-next.202604010134-27d76e8",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI using -next for others to test this PR, otherwise, we should wait for 0.7.0 to come out @feloy

@cdrage cdrage marked this pull request as draft April 2, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bootc logs are spamming console log with spawn errors when macadam is not installed

1 participant