Fix test for deferred indexing queue processing#602
Merged
mauritsvanrees merged 3 commits intomainfrom Mar 24, 2026
Merged
Conversation
Since Products.CMFCore 3.9, reindexObjectSecurity no longer calls processQueue() mid-request. The indexing queue may defer catalog operations until the next search or transaction commit. Adapt test_create_raises_unicodedecodeerror to explicitly flush the queue so the broken indexer is invoked inside the assertRaises block. Refs: plone/buildout.coredev#1080
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Member
Author
|
@jenkins-plone-org please run jobs |
Member
Author
|
@jenkins-plone-org please run jobs |
mauritsvanrees
approved these changes
Mar 24, 2026
Member
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
This helps when using latest Products.CMFCore. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reindexObjectSecurityno longer callsprocessQueue()mid-request (Update user.py #155)test_create_raises_unicodedecodeerrorrelied on the queue being flushed synchronously duringapi.content.create()processQueue()call inside theassertRaisesblock so the broken indexer is invokedRefs: plone/buildout.coredev#1080, zopefoundation/Products.CMFCore#160
🤖 Generated with Claude Code
📚 Documentation preview 📚: https://ploneapi--602.org.readthedocs.build/