Skip to content

remove limit threshold #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manas (manas-plivo) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove limit threshold #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/plivo/resources/brand.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ def list(options=nil)
params[param] = options[param]
end
end
if options.key?(:limit) && (options[:limit] > 20 || options[:limit] <= 0)
raise_invalid_request('The maximum number of results that can be '\
"fetched is 20. limit can't be more than 20 or less than 1")
end
if options.key?(:offset) && options[:offset] < 0
raise_invalid_request("Offset can't be negative")
end
Expand Down
8 changes: 0 additions & 8 deletions lib/plivo/resources/campaign.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ def list(options=nil)
params[param] = options[param]
end
end
if options.key?(:limit) && (options[:limit] > 20 || options[:limit] <= 0)
raise_invalid_request('The maximum number of results that can be '\
"fetched is 20. limit can't be more than 20 or less than 1")
end
if options.key?(:offset) && options[:offset] < 0
raise_invalid_request("Offset can't be negative")
end
Expand Down Expand Up @@ -98,10 +94,6 @@ def get_numbers(campaign_id, options = nil)
params[param] = options[param]
end
end
if options.key?(:limit) && (options[:limit] > 20 || options[:limit] <= 0)
raise_invalid_request('The maximum number of results that can be '\
"fetched is 20. limit can't be more than 20 or less than 1")
end
if options.key?(:offset) && options[:offset] < 0
raise_invalid_request("Offset can't be negative")
end
Expand Down
4 changes: 0 additions & 4 deletions lib/plivo/resources/profile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ def list(options = nil)
params[param] = options[param]
end
end
if options.key?(:limit) && (options[:limit] > 20 || options[:limit] <= 0)
raise_invalid_request('The maximum number of results that can be '\
"fetched is 20. limit can't be more than 20 or less than 1")
end
if options.key?(:offset) && options[:offset] < 0
raise_invalid_request("Offset can't be negative")
end
Expand Down