Julenmendieta/MILAB-6010_peptideDiscovery#57
Merged
julenmendieta merged 3 commits intomainfrom Apr 10, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the biopython dependency to the Python 3.12.10 environment configuration and includes a corresponding changeset. A review comment points out that the specified version 1.87 for biopython is likely incorrect as it is not available on PyPI, which will cause the build to fail.
| "Cython==3.1.4", | ||
| "fa2_modified==0.4" | ||
| "fa2_modified==0.4", | ||
| "biopython==1.87" |
There was a problem hiding this comment.
The version 1.87 for biopython does not appear to be available on PyPI (the latest stable release is 1.86). If this is not a custom internal version or hosted on a private registry, the build will fail when attempting to download the package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.