Conversation
Contributor
Author
|
@manhtai please take a look, if everything is okay then I will polish the UI and finalize this MR |
Member
|
@dmtri The MR looks great, I have some points to discuss though:
Again, nice work 💪 |
Contributor
Author
|
Member
|
Contributor
Author
|
@manhtai I see, watching argument changes in view mode is reasonable but watching function changes in render mode feels kinda wrong to me (user might not want auto run on every change) 😅 |
Member
|
@dmtri Yes, when in edit mode we shouldn't let the function run with every change, but when in view mode it is reasonable, just like every other built-in one ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.