unit test: Add parallel encoding regression test#143
Open
hanguyen-nuro wants to merge 1 commit intomasterfrom
Open
unit test: Add parallel encoding regression test#143hanguyen-nuro wants to merge 1 commit intomasterfrom
hanguyen-nuro wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 42.23% 42.23%
=======================================
Files 18 18
Lines 1636 1636
=======================================
Hits 691 691
Misses 886 886
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test that processEncodedFrames encodes tracks in parallel by injecting 10 mock tracks with 50ms encode delay each. Asserts total wall time < 150ms (3x single-encode), which would fail at ~500ms if tracks were processed sequentially. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e095043 to
6d97fbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test to ensure
processEncodedFramesprocesses tracks in parallel. This guards against future changes that might inadvertently serialize VP8 encoding.How it works
Read()processEncodedFrames()and measures wall-clock timeVerified
processEncodedFrames(current master): ~50msFlakiness
-count=10: 10/10 pass🤖 Generated with Claude Code