feat(client): improve register command error handling#117
Merged
xia0pin9 merged 3 commits intopinterest:masterfrom Jan 14, 2026
Merged
feat(client): improve register command error handling#117xia0pin9 merged 3 commits intopinterest:masterfrom
xia0pin9 merged 3 commits intopinterest:masterfrom
Conversation
Functional improvements: - Add validation: -g flag now requires -k to prevent crashes - Support uncached mode with -g -k for direct key fetching - Extract fetchAndPrintKey() function for better code organization - Improve timeout handling with proper deadline checks - Add comprehensive documentation for uncached mode behavior Bug fixes: - Prevent crash when -g used without -k specified - Better error messages distinguishing 'daemon' vs 'server' Code quality: - Apply log standardization (lowercase messages, %w wrapping) - Add detailed comments explaining timeout limitations - Improve code structure and readability Tests pass independently of other log standardization changes.
csstaub
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional improvements:
Bug fixes:
Code quality:
Tests pass independently of other log standardization changes.