Handle passing an account when posting sendupdate#1
Closed
wi-ski wants to merge 3 commits intopinheadmz:reveal1from
Closed
Handle passing an account when posting sendupdate#1wi-ski wants to merge 3 commits intopinheadmz:reveal1from
wi-ski wants to merge 3 commits intopinheadmz:reveal1from
Conversation
Adds new method hasCoinByAccount(acct, hash, index) to txdb which returns true if the coin (hash, index) is owned by account (number). Adds this check to wallet.makeReveal() to prevent BIDs from other wallet accounts being included as inputs to a new REVEAL TX from a specific account.
This was referenced Aug 5, 2019
pinheadmz
force-pushed
the
reveal1
branch
3 times, most recently
from
b0b02ae to
ec2bdc8
Compare
Owner
|
added at handshake-org@d952bcb |
Author
|
lol. Dang man, I was hoping to get that contributor badge. |
Owner
|
Yeah sorry man. I wanted to fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Originally, issue handshake-org#231 brought up a similar issue surrounding
sendRevealand specifying accounts. This work aims to extend handshake-org#233It raises an exception when passed an account that does not match the would-be coin's owner:
https://github.com/pinheadmz/hsd/pull/1/files#diff-10775d9a238b8247721a7dc0600d5a8aR2360
Todo