Skip to content

Implement approved plans in new worktrees#819

Open
Mitch515 wants to merge 2 commits intopingdotgg:mainfrom
Mitch515:pr/plan-implementation-worktrees
Open

Implement approved plans in new worktrees#819
Mitch515 wants to merge 2 commits intopingdotgg:mainfrom
Mitch515:pr/plan-implementation-worktrees

Conversation

@Mitch515
Copy link

@Mitch515 Mitch515 commented Mar 10, 2026

What Changed

  • add a UI flow for taking an approved plan and starting implementation in a new worktree
  • wire the approved-plan action into the existing chat and plan UI flow
  • add supporting behavior needed for the new-worktree implementation path

Why

  • approving a plan should lead directly into isolated implementation without requiring manual worktree setup first
  • the plan UI becomes more useful when it can hand off into the next concrete step

UI Changes

  • screenshots and video are attached in the PR asset comment

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes, if applicable

Note

Implement approved plans in new git worktrees from ChatView

  • Adds an 'Implement in new worktree' option to the plan implementation menu in ChatView.tsx, creating a new git worktree from the current branch before starting the implementation thread.
  • Sequences worktree creation, optional setup script execution, thread creation, and navigation via a new startImplementationThread helper; cleans up orphaned threads if later steps fail.
  • On failure after worktree creation, shows an AlertDialog offering to keep or delete the partially created worktree, with delete triggering api.git.removeWorktree and a git query invalidation.
  • Extends the browser test harness in ChatView.browser.tsx with per-tag WS RPC overrides and adds three test cases covering menu visibility, successful worktree creation, and rollback UI on failure.
  • Risk: startImplementationThread error handling depends on cleanupImplementationThreadCreation succeeding silently; if the orchestration dispatch also fails, the thread may still be orphaned.

Macroscope summarized f0f98a1.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e6fe4872-4354-468b-81c9-b8520b4c8f13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 10, 2026
@Mitch515
Copy link
Author

Assets for review:

Implementation actions screenshot:

Implementation actions

Muted video:

@Mitch515 Mitch515 marked this pull request as ready for review March 10, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant