Skip to content

fix: Linux icon now shows up#807

Open
alexsch01 wants to merge 1 commit intopingdotgg:mainfrom
alexsch01:linuxIcon
Open

fix: Linux icon now shows up#807
alexsch01 wants to merge 1 commit intopingdotgg:mainfrom
alexsch01:linuxIcon

Conversation

@alexsch01
Copy link

@alexsch01 alexsch01 commented Mar 10, 2026

What Changed

In production, add prod-resources as a path that is a copy of stageResourcesDir
Fixes Linux icon not showing up

Why

electron-builder is filtering out STAGE_APP_DIR/apps/desktop/resources directory in the AppImage
(this may happen on the other platforms as well)

Checklist

  • This PR is small and focused
  • I explained what changed and why

Other

I manually tested that the Dev icon shows the correct icon and the Prod icon shows the correct but different icon

Summary by CodeRabbit

  • Chores
    • Enhanced desktop application build and resource resolution processes to improve asset discovery and reliability during application startup.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b44d9ac1-bb52-4c06-a5f3-eabbd35b4411

📥 Commits

Reviewing files that changed from the base of the PR and between 223c3dc and c3fc8a4.

📒 Files selected for processing (2)
  • apps/desktop/src/main.ts
  • scripts/build-desktop-artifact.ts

📝 Walkthrough

Walkthrough

The PR introduces resource resolution from a new prod-resources directory. The build script now copies resources to apps/desktop/prod-resources during artifact staging, and the main process checks this path as a fallback when resolving resource locations.

Changes

Cohort / File(s) Summary
Resource Path Resolution
apps/desktop/src/main.ts
Adds prod-resources as an additional candidate path in resource resolution logic, checked after the existing resources folder.
Build Staging Process
scripts/build-desktop-artifact.ts
Adds a file copy operation to stage the resources directory into apps/desktop/prod-resources during artifact build preparation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little prod-resources seed we plant,
Where icons and assets nest and grant,
The build script copies with care so fine,
And main.ts finds them—oh, how they shine!
Resources doubled, fallback so neat,
This rabbit's work is quite complete! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main fix: resolving the Linux icon display issue in production builds.
Description check ✅ Passed The description includes filled sections for 'What Changed' and 'Why', explaining the problem and solution; checklist items are marked; however, 'UI Changes' section was not addressed despite being template guidance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 10, 2026
@alexsch01
Copy link
Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant