Sync desktop native theme with web theme setting#800
Sync desktop native theme with web theme setting#800juliusmarminge merged 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- add `desktop:set-theme` IPC channel and bridge method - validate theme values in Electron main process - propagate web theme changes to Electron `nativeTheme` with deduped sync
beca909 to
cab2240
Compare
What Changed
Updated the window theme to match the app theme configured in the settings page.
Why
Currently, the window title bar follows the system theme rather than the app theme. This is problematic on Windows as we use the default title bar.
UI Changes
Not sure what the deal is with the bitrate, will have to figure that out at not 12am.
Before:
You can see that the window title bar always follows the system colour, regardless of the theme setting.
explorer_av2gXFabJ6.mp4
After:
We now respect the theme setting.
explorer_NsRBucWdL4.mp4
Checklist
Note
Sync Electron's native theme with the web app's theme setting
setThememethod towindow.desktopBridge(via preload.ts) that sends the active theme over thedesktop:set-themeIPC channel.nativeTheme.themeSourceaccordingly.applyThemeinvocation, with deduplication to avoid redundant IPC calls and retry logic on failure.Macroscope summarized cab2240.