Skip to content

distinct instance of headers dict#65

Open
mullinmax wants to merge 1 commit intopimoroni:mainfrom
mullinmax:patch/response_headers
Open

distinct instance of headers dict#65
mullinmax wants to merge 1 commit intopimoroni:mainfrom
mullinmax:patch/response_headers

Conversation

@mullinmax
Copy link
Copy Markdown

I found this bug when returning custom response headers.

the {} is declared once when you define the class and reused between instances, so once you return a specific header it will automatically end up on every request.

Sorry I didn't open an issue first, I figured this was easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant