Skip to content

Pin redis and add ssl #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bluvulture wants to merge 5 commits into
base: 4.x
Choose a base branch
from
Draft

Pin redis and add ssl #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39ecf26
Pin redis and add ssl
bluvulture Mar 13, 2026
0b695c0
Update checkout v4
bluvulture Mar 13, 2026
9674191
Update skeleton 2025.4
bluvulture Mar 13, 2026
70711ff
Apply suggestions from code review
bluvulture Mar 13, 2026
baeed91
Fix redis version
bluvulture Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- { php: '8.3', distro: bookworm }
- { php: '8.4', distro: bookworm }
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Build Image
run: |
set -ex
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
docker run --rm pimcore-image test ! -f /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
fi

docker run --rm pimcore-image composer create-project pimcore/skeleton:2025.x-dev pimcore --no-scripts
docker run --rm pimcore-image composer create-project pimcore/skeleton:2025.4.0 pimcore --no-scripts

if [ "$imageVariant" != "min" ]; then
docker run -v "$(pwd)/.github/files":/var/www/html --rm pimcore-image php test_heif.php
Expand Down
7 changes: 6 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

ARG PHP_VERSION="8.4"
ARG DEBIAN_VERSION="bookworm"
ARG REDIS_EXT_VERSION="6.0.0"

FROM php:${PHP_VERSION}-fpm-${DEBIAN_VERSION} AS pimcore_php_min

Expand All @@ -25,7 +26,9 @@ RUN set -eux; \
libicu-dev \
libjpeg62-turbo-dev \
libpng-dev \
libssl-dev \
libzip-dev \
openssl \
zlib1g-dev \
librabbitmq-dev \
; \
Expand Down Expand Up @@ -99,6 +102,8 @@ CMD ["php-fpm"]

FROM pimcore_php_min AS pimcore_php_default

ARG REDIS_EXT_VERSION

RUN set -eux; \
\
build-install.sh; \
Expand Down Expand Up @@ -143,7 +148,7 @@ RUN set -eux; \
pecl install -f \
apcu \
imagick \
redis \
redis-${REDIS_EXT_VERSION} \
; \
docker-php-ext-enable \
apcu \
Expand Down
Loading