[node] Deprecate GLOBAL in favor of global

[sigv]

The GLOBAL variable should not be used in order to avoid DeprecationWarning: 'GLOBAL' is deprecated, use 'global'.

[sigv]

This PR is a replacement for #1880.

[FooBarWidget]

Thanks for the rebase. There is only one concern I have, and that is compatibility. You mentioned that the lowercase global was introduced in Node.js 6. We want to be compatible with at least the current LTS version so at the very least it needs to be compatible with Node.js 4. Maybe you can add some kind of if statement there to ensure compatibility?

And can I ask you to fill in our contributor agreement if you haven't filled it in already? We need it before can merge pull requests.

[sigv]

As I said in the old PR, this commit marks the GLOBAL being deprecated.

It was initially added back in the day with official documentation up until version 0.1.26.
In 0.1.27, the GLOBAL was renamed global. See Downcase process.ARGV, process.ENV, GLOBAL (now process.argv, process.env, global) in changelog and global instead of GLOBAL in documentation.

With that in mind, I do not see how this change can break compatibility even if you support versions down to 0.10.x. Even more so, in all other uses of the global object in the project, it is already used as global and not GLOBAL. (Example.)

[sigv]

Oh, and I have signed the agreement but I have not signed the commit. Is that okay for you guys?

[FooBarWidget]

Ah I see, then I misunderstood. I thought you meant that in version 6 global was introduced and GLOBAL was deprecated, but global has existed for much longer. That's fine then.

[FooBarWidget]

It's been merged now, and I've added you to the CONTRIBUTORS file. Thanks again for the pull request!

[sigv]

What exactly is the release schedule of Passenger?
Is there some ETA for this to be released in an official open-source build of Passenger?

[OnixGH]

It's merged to stable, so it's for the upcoming release. We typically release a few times per quarter.