Fix internal return type check with gcov#21653
Merged
iluuu1994 merged 1 commit intophp:masterfrom Apr 6, 2026
Merged
Conversation
ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out of ZEND_ASSERT().
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21653 +/- ##
=======================================
Coverage 69.23% 69.24%
=======================================
Files 812 812
Lines 296933 296957 +24
Branches 84521 84533 +12
=======================================
+ Hits 205577 205621 +44
+ Misses 56636 56616 -20
Partials 34720 34720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ayesh
pushed a commit
to Ayesh/php-src
that referenced
this pull request
Apr 7, 2026
ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out of ZEND_ASSERT().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out of ZEND_ASSERT().