Skip to content

Fix internal return type check with gcov#21653

Merged
iluuu1994 merged 1 commit intophp:masterfrom
iluuu1994:gcov-fix-internal-return-type-check
Apr 6, 2026
Merged

Fix internal return type check with gcov#21653
iluuu1994 merged 1 commit intophp:masterfrom
iluuu1994:gcov-fix-internal-return-type-check

Conversation

@iluuu1994
Copy link
Copy Markdown
Member

ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out of ZEND_ASSERT().

ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out
of ZEND_ASSERT().
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.24%. Comparing base (6daf99f) to head (6d3a47d).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
Zend/zend_vm_execute.h 86.36% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21653   +/-   ##
=======================================
  Coverage   69.23%   69.24%           
=======================================
  Files         812      812           
  Lines      296933   296957   +24     
  Branches    84521    84533   +12     
=======================================
+ Hits       205577   205621   +44     
+ Misses      56636    56616   -20     
  Partials    34720    34720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iluuu1994 iluuu1994 merged commit 5279185 into php:master Apr 6, 2026
20 checks passed
Ayesh pushed a commit to Ayesh/php-src that referenced this pull request Apr 7, 2026
ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out
of ZEND_ASSERT().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant