Skip to content

Zend: add test for reading $http_response_header without explicit assignment which triggers deprecation warning #21633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 4 commits into from
Apr 6, 2026
+16 −1
Merged

Zend: add test for reading $http_response_header without explicit assignment which triggers deprecation warning #21633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a8b376
add tests
LamentXU123 Apr 4, 2026
2288cb1
Revert "add tests"
LamentXU123 Apr 6, 2026
ec52f5b
Create http_response_header_deprecated_dynamic_fetch.phpt
LamentXU123 Apr 6, 2026
c631c6b
delete TODO message
LamentXU123 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2971,7 +2971,6 @@ static zend_op *zend_compile_simple_var_no_cv(znode *result, const zend_ast *ast

opline->extended_value = ZEND_FETCH_GLOBAL;
} else {
// TODO: Have a test case for this?
if (name_node.op_type == IS_CONST
&& type == BP_VAR_R
&& zend_string_equals_literal(Z_STR(name_node.u.constant), "http_response_header")) {
Expand Down
16 changes: 16 additions & 0 deletions ext/standard/tests/http/http_response_header_deprecated_dynamic_fetch.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--TEST--
$http_response_header dynamic fetch should warn
--FILE--
<?php

function http_response_header() {
${__FUNCTION__} = "OK";
var_dump(${__FUNCTION__});
}

http_response_header();

?>
--EXPECTF--
Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in %s on line %d
string(2) "OK"
Loading