Fix GH-21617: sni_server self signed certifcate expired#21628
Merged
bukka merged 1 commit intophp:PHP-8.2from Apr 3, 2026
Merged
Fix GH-21617: sni_server self signed certifcate expired#21628bukka merged 1 commit intophp:PHP-8.2from
bukka merged 1 commit intophp:PHP-8.2from
Conversation
bukka
force-pushed
the
openssl_sni_certs_renewal
branch
from
70d79e2 to
ea82c3c
Compare
bukka
force-pushed
the
openssl_sni_certs_renewal
branch
from
ea82c3c to
829d9a7
Compare
iluuu1994
approved these changes
Apr 3, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM, with my limited knowledge.
It changes the SNI tests to use certificate generator like other TLS tests. Closes phpGH-21628
bukka
force-pushed
the
openssl_sni_certs_renewal
branch
from
829d9a7 to
0f38bfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the SNI tests to use certificate generator like other TLS tests.