Skip to content

ext/mysqli: add a const qualifier in mysqli_objects_new()#21510

Merged
Girgias merged 1 commit intophp:masterfrom
Girgias:const-mysqli-2026-03
Mar 24, 2026
Merged

ext/mysqli: add a const qualifier in mysqli_objects_new()#21510
Girgias merged 1 commit intophp:masterfrom
Girgias:const-mysqli-2026-03

Conversation

@Girgias
Copy link
Copy Markdown
Member

@Girgias Girgias commented Mar 24, 2026

No description provided.

@Girgias Girgias changed the title ext/mysqli: add some const qualifiers ext/mysqli: add a const qualifier in mysqli_objects_new() Mar 24, 2026
Copy link
Copy Markdown
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the benefit is, but it looks ok to me.

@Girgias
Copy link
Copy Markdown
Member Author

Girgias commented Mar 24, 2026

I'm not sure what the benefit is, but it looks ok to me.

I was attempting to see if the parent field of a CE can be made const. But there are various other issues preventing it. But it is IMHO good practice to have something be const if it can.

@Girgias Girgias merged commit 118fa2c into php:master Mar 24, 2026
19 checks passed
@Girgias Girgias deleted the const-mysqli-2026-03 branch March 24, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants